[webkit-reviews] review granted: [Bug 119365] [BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92 : [Attachment 207891] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jacky Jiang <jkjiang at webkit.org>'s
request for review:
Bug 119365: [BlackBerry] Page scrolls when width equals device width and
initial scale is greater than 0.92
https://bugs.webkit.org/show_bug.cgi?id=119365

Attachment 207891: Patch
https://bugs.webkit.org/attachment.cgi?id=207891&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207891&action=review


Looks good in general.

> Source/WebKit/blackberry/Api/WebPage.cpp:1704
> +    float idealContentsHeight =
static_cast<float>(this->transformedActualVisibleSize().height()) /
devicePixelRatio;

Are you sure this-> is needed here?

> Source/WebKit/blackberry/Api/WebPage.cpp:1708
> +    return false;

You could replace the if with a return, and then you don't need the return
false; statement.