[webkit-reviews] review denied: [Bug 119137] [CSS Regions] Selecting text through different regions flow does not match with highlight : [Attachment 207639] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 119137: [CSS Regions] Selecting text through different regions flow does
not match with highlight
https://bugs.webkit.org/show_bug.cgi?id=119137

Attachment 207639: Patch
https://bugs.webkit.org/attachment.cgi?id=207639&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207639&action=review


> Source/WebCore/editing/FrameSelection.cpp:307
> +    if (atDifferentFlowThread(s.base(), s.extent()))
> +	   return;
> +

This is not the right place to fix this. We need to do this inside
VisibleSelection::validate probably right before or right after we call
adjustSelectionToAvoidCrossingShadowBoundaries.