[webkit-reviews] review granted: [Bug 119351] [Windows] Winlauncher shouldn't look for Safari Install Directory : [Attachment 207877] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 31 15:29:52 PDT 2013


Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 119351: [Windows] Winlauncher shouldn't look for Safari Install Directory
https://bugs.webkit.org/show_bug.cgi?id=119351

Attachment 207877: Patch
https://bugs.webkit.org/attachment.cgi?id=207877&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207877&action=review


> Tools/win/DLLLauncher/DLLLauncherMain.cpp:124
> +static bool directoryExists(wstring path)

I suggest const wstring& here.


More information about the webkit-reviews mailing list