[webkit-reviews] review denied: [Bug 119327] Replace CRASH() on overflow with Checked<> : [Attachment 207813] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 31 14:07:43 PDT 2013
Oliver Hunt <oliver at apple.com> has denied Kwang Yul Seo
<skyul at company100.com>'s request for review:
Bug 119327: Replace CRASH() on overflow with Checked<>
https://bugs.webkit.org/show_bug.cgi?id=119327
Attachment 207813: Patch
https://bugs.webkit.org/attachment.cgi?id=207813&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207813&action=review
> Source/WebCore/platform/audio/AudioArray.h:55
> void allocate(size_t n)
Make n Checked<size_t>, otherwise the multiplication below may silently fail
before the arithmetic becomes safe.
More information about the webkit-reviews
mailing list