[webkit-reviews] review denied: [Bug 119277] Reduce JSC API static value setter/getter overhead : [Attachment 207866] avoid to create OpaqueJSString every time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 31 13:19:18 PDT 2013


Geoffrey Garen <ggaren at apple.com> has denied Yi Shen
<max.hong.shen at gmail.com>'s request for review:
Bug 119277: Reduce JSC API static value setter/getter overhead
https://bugs.webkit.org/show_bug.cgi?id=119277

Attachment 207866: avoid to create OpaqueJSString every time
https://bugs.webkit.org/attachment.cgi?id=207866&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This looks good, but it leaves the code in a bit of a confused state, because
now getters build in a propertyNameRef, but setters still call "propertyNameRef
= OpaqueJSString::create(name);", and it's not clear why. Can you update
setters to match getters as well?


More information about the webkit-reviews mailing list