[webkit-reviews] review denied: [Bug 61276] <input type=color> Mac UI behaviour : [Attachment 207808] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 61276: <input type=color> Mac UI behaviour
https://bugs.webkit.org/show_bug.cgi?id=61276

Attachment 207808: Patch
https://bugs.webkit.org/attachment.cgi?id=207808&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207808&action=review


I think I know why this broke the Windows build.  Everything else looks fine.

r- for now, but please upload a new patch to fix the windows build and i'll r+
that.

> Source/WTF/wtf/FeatureDefines.h:507
>  #if !defined(ENABLE_INPUT_TYPE_COLOR)
> -#define ENABLE_INPUT_TYPE_COLOR 0
> +#define ENABLE_INPUT_TYPE_COLOR 1
>  #endif

I think the reason the windows build broke was because this clause globally
enables the feature on all platforms that haven't decided to enable/disable it
earlier in FeatureDefines.h

You should probably leave this clause alone, and add a new "#define
ENABLE_INPUT_TYPE_COLOR 1" clause to the "/* --------- Apple MAC port (not IOS)
--------- */" section of the file.