[webkit-reviews] review granted: [Bug 119229] [CSS Shapes] Stop using internals in shape-outside tests : [Attachment 207678] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 119229: [CSS Shapes] Stop using internals in shape-outside tests
https://bugs.webkit.org/show_bug.cgi?id=119229

Attachment 207678: Patch
https://bugs.webkit.org/attachment.cgi?id=207678&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207678&action=review


Looks a lot better. Please update SUBPIXELS_FOR_PIXEL back to
SUBPIXELS_PER_PIXEL before committing.

>
LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:21

> +	       return isEnabled() ? Math.floor(f * SUBPIXELS_FOR_PIXEL) /
SUBPIXELS_FOR_PIXEL : Math.floor(f); // as in LayoutUnit(f).toFloat()

Why do you need this change?

>
LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:24

> +	       return isEnabled() ? Math.ceil(f * SUBPIXELS_FOR_PIXEL) /
SUBPIXELS_FOR_PIXEL : Math.ceil(f); // see ceiledLayoutUnit(), LayoutUnit.h

ditto