[webkit-reviews] review denied: [Bug 109422] [Qt] Add Page Visibility API support : [Attachment 206449] New QWebPage API (with test): void QWebPage::setVisibilityState(bool visible) (2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 31 07:37:47 PDT 2013


Benjamin Dupont <bdupont at nds.com> has denied Benjamin Dupont
<bdupont at nds.com>'s request for review:
Bug 109422: [Qt] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=109422

Attachment 206449: New QWebPage API (with test): void
QWebPage::setVisibilityState(bool visible) (2)
https://bugs.webkit.org/attachment.cgi?id=206449&action=review

------- Additional Comments from Benjamin Dupont <bdupont at nds.com>
After IRC discussion with carewolf, jturcotte and tronical, I'll provide a new
patch with:
- enum with different states (also optionals)
- Q_PROPERTY
- QWebPage::setVisibilityState
- QWebPage::visibilityState
- more comments regarding:
--- the initial state,
--- the propagation until the JS
--- how/where/when to call it


More information about the webkit-reviews mailing list