[webkit-reviews] review denied: [Bug 119277] Reduce JSC API static value setter/getter overhead : [Attachment 207770] proposal patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 17:18:55 PDT 2013


Geoffrey Garen <ggaren at apple.com> has denied Yi Shen
<max.hong.shen at gmail.com>'s request for review:
Bug 119277: Reduce JSC API static value setter/getter overhead
https://bugs.webkit.org/show_bug.cgi?id=119277

Attachment 207770: proposal patch
https://bugs.webkit.org/attachment.cgi?id=207770&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I don't think we should fix this with a special attribute. What about all our
existing clients that don't use the attribute?

Let's optimize this path not to call OpaqueJSString::create() every time.


More information about the webkit-reviews mailing list