[webkit-reviews] review granted: [Bug 16739] XMLSerializer should reset default namespace when necessary : [Attachment 206894] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 16739: XMLSerializer should reset default namespace when necessary
https://bugs.webkit.org/show_bug.cgi?id=16739

Attachment 206894: Patch
https://bugs.webkit.org/attachment.cgi?id=206894&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206894&action=review


> Source/WebCore/editing/MarkupAccumulator.cpp:303
> +	       result.append(xmlnsAtom.string());

Maybe we should probably add a version of append that takes AtomicString.

> Source/WebCore/editing/MarkupAccumulator.cpp:306
> +	       result.append('=');
> +	       result.append('"');
> +	       result.append('"');

Why can't we just do result.appendLiteral("=\"\"");?

> LayoutTests/fast/dom/XMLSerializer-element-empty-namespace-expected.txt:2
> +<div xmlns="http://www.w3.org/1999/xhtml" id="target"> <div id="output">
</div><a xmlns="" href="#"/></div>
> +

It'll be nice if the test had some description on what it's testing.

> LayoutTests/fast/dom/XMLSerializer-element-empty-namespace2-expected.txt:1
> +<x xmlns="foo"><y xmlns=""/></x>

Ditto.