[webkit-reviews] review denied: [Bug 71152] selectors should match attribute name with case sensitivity based on element & document type : [Attachment 207766] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 71152: selectors should match attribute name with case sensitivity based on
element & document type
https://bugs.webkit.org/show_bug.cgi?id=71152

Attachment 207766: Patch
https://bugs.webkit.org/attachment.cgi?id=207766&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207766&action=review


> Source/WebCore/dom/QualifiedName.cpp:148
> +    ASSERT(m_impl->m_localNameUpperLower.impl() ==
m_impl->m_localName.upper().impl());

This assertion will fail. You need to check if the strings are equal, not that
they have the same StringImpl pointer. I think you should just remove the calls
to impl().

> Source/WebCore/dom/QualifiedName.cpp:156
> +    ASSERT(m_impl->m_localNameUpperLower.impl() ==
m_impl->m_localName.lower().impl());

Same problem.