[webkit-reviews] review granted: [Bug 119210] [WIN] Add implementation for WebCore::readFromFile() : [Attachment 207627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 10:16:38 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 119210: [WIN] Add implementation for WebCore::readFromFile()
https://bugs.webkit.org/show_bug.cgi?id=119210

Attachment 207627: Patch
https://bugs.webkit.org/attachment.cgi?id=207627&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207627&action=review


r=me.  Please consider adding the global namespace prefix to the ReadFile
method call.

> Source/WebCore/platform/win/FileSystemWin.cpp:393
> +    bool success = ReadFile(handle, data, length, &bytesRead, 0);

We prefer to say "::ReadFile" for these global WinAPI calls.


More information about the webkit-reviews mailing list