[webkit-reviews] review granted: [Bug 117984] Rearrange the code of FrameWin : [Attachment 205392] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 117984: Rearrange the code of FrameWin
https://bugs.webkit.org/show_bug.cgi?id=117984

Attachment 205392: Patch
https://bugs.webkit.org/attachment.cgi?id=205392&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205392&action=review


I think the imageFromRect method should take a const Frame* argument. 
Otherwise, this looks good to me.  Please correct the const when you land it.

> Source/WebCore/page/win/FrameCGWin.cpp:52
> +PassOwnPtr<HBITMAP> imageFromRect(Frame* frame, IntRect& ir)

Why remove the 'const' from the Frame* argument?