[webkit-reviews] review denied: [Bug 117823] [Qt] Add interface API for origin whitelisting : [Attachment 207709] Modified the patch as per suggestions.

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Deepjyoti Saha
<deesaha at cisco.com>'s request for review:
Bug 117823: [Qt] Add interface API for origin whitelisting
https://bugs.webkit.org/show_bug.cgi?id=117823

Attachment 207709: Modified the patch as per suggestions.
https://bugs.webkit.org/attachment.cgi?id=207709&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207709&action=review


> Source/WebKit/qt/Api/qwebsecurityorigin.cpp:295
> +    Passing AllowSubdomains in \a subdomainSetting will allow the source
origin to access
> +    the \a host's subdomains as well, whereas passing DisallowSubdomains
would prevent this.

In the case of removing, this documentation is misleading. Something like
"using the specified \a scheme *and \a subdomainSetting.*" would be fine here.