[webkit-reviews] review denied: [Bug 119240] [EFL] REGRESSION after r153439: layout tests do not run. : [Attachment 207704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 03:09:35 PDT 2013


Christophe Dumez <dchris at gmail.com> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 119240: [EFL] REGRESSION after r153439: layout tests do not run.
https://bugs.webkit.org/show_bug.cgi?id=119240

Attachment 207704: Patch
https://bugs.webkit.org/attachment.cgi?id=207704&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207704&action=review


> Tools/Scripts/webkitpy/port/efl.py:136
> +	   return super(EflPort, self).check_sys_deps(needs_http) and
XvfbDriver.check_driver(self)

Please use self._driver_class().check_driver(self) for consistency with gtk.


More information about the webkit-reviews mailing list