[webkit-reviews] review denied: [Bug 15078] REGRESSION (r21387): Find on page can scroll overflow:hidden boxes to reveal found text : [Attachment 207663] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 15078: REGRESSION (r21387): Find on page can scroll overflow:hidden boxes
to reveal found text
https://bugs.webkit.org/show_bug.cgi?id=15078

Attachment 207663: Patch
https://bugs.webkit.org/attachment.cgi?id=207663&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
I am not sure what is the intended behavior with this patch, and I don’t know
whether it’s desirable. This patch is not just “ignoring hits”, it is eliding
text from everything that uses the text iterator (such as innerText and the
plain-text pasteboard item). It also tries to consider the entire text node, of
which some lines (or parts thereof) may be clipped out, and others may not, and
the match may occur in either the former or the latter. It also considers
overflow-y and not overflow-x, and looks at the renderer’s enclosing layer and
ignores other ancestor layers.