[webkit-reviews] review granted: [Bug 118966] [ATK] Implement allAttributes() for AccessibilityUIElement : [Attachment 207521] Patch proposal

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 118966: [ATK] Implement allAttributes() for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118966

Attachment 207521: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=207521&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207521&action=review


> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:76
> +    GString* str = g_string_new(0);

Might be worth it taking advantage of the change to use StringBuilder and
String here =)

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:241
> +	   if (parentName && g_utf8_strlen(parentName, -1)) {
> +	       attributeLine.set(g_strdup_printf(": %s", parentName));
> +
> +	   }

No need for braces, empty line

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:257
> +	   attributeLine.set(g_strdup_printf("%s\n", title.utf8().data()));

How about using String::format("%s\n", title.utf8().data())? Then you can have
attributeLine live on the stack and avoid dealing with char pointers.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:303
> +    // We append the ATK specific attributes as a single line at the end.
> +    GOwnPtr<char>
attributeData(getAtkAttributeSetAsString(element->platformUIElement()));
> +    attributeLine.set(g_strdup_printf("AXPlatformAttributes: %s",
attributeData.get()));
> +    builder.append(attributeLine.get());

Ditto.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:493
> -    String roleString = roleToString(role);
> -    return JSStringCreateWithUTF8CString(roleString.utf8().data());
> +    GOwnPtr<char> roleStringWithPrefix(g_strdup_printf("AXRole: %s",
roleToString(role)));
> +    return JSStringCreateWithUTF8CString(roleStringWithPrefix.get());

Ditto.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:292
> +    attributeLine.set(g_strdup_printf("%s\n",
element->role()->string().utf8().data()));
> +    builder.append(attributeLine.get());

This file also has a number of potential changes from char* to String.