[webkit-reviews] review granted: [Bug 119199] Don't update the text track override CSS every time a media element is created. : [Attachment 207617] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119199: Don't update the text track override CSS every time a media element
is created.
https://bugs.webkit.org/show_bug.cgi?id=119199

Attachment 207617: Patch
https://bugs.webkit.org/attachment.cgi?id=207617&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207617&action=review


> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:238
> +	   updateCaptionStyleSheetOveride();

I would suggest instead changing this function to use early return if already
listening for preference changes rather than nesting all this code inside an if
statement.