[webkit-reviews] review granted: [Bug 119031] Logging should be configurable using human-readable channel names rather than crazy bitmasks : [Attachment 207580] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 119031: Logging should be configurable using human-readable channel names
rather than crazy bitmasks
https://bugs.webkit.org/show_bug.cgi?id=119031

Attachment 207580: Patch v1
https://bugs.webkit.org/attachment.cgi?id=207580&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207580&action=review


> Source/WTF/wtf/Assertions.cpp:440
> +    String nameString = name;

It seems unfortunate to create String just to do equalIgnoringCase.  Can we add
an override that takes only const char*s?

> Source/WTF/wtf/Assertions.cpp:463
> +	   String component = components[i];

It might be nice to allow for whitespace, thoughts?

> Source/WTF/wtf/Assertions.cpp:476
> +	   if (WTFLogChannel* channel = WTFLogChannelByName(channels, count,
component.utf8().data()))

If we don't fix the above issue, it seems unfortunate to to pull out the data
only to construct a String in WTFLogChannelByName.