[webkit-reviews] review granted: [Bug 119168] Add support infrastructure for iOS WebKit port : [Attachment 207559] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 119168: Add support infrastructure for iOS WebKit port
https://bugs.webkit.org/show_bug.cgi?id=119168

Attachment 207559: Patch
https://bugs.webkit.org/attachment.cgi?id=207559&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207559&action=review


> Tools/Scripts/webkitdirs.pm:1720
> -    if (isAppleMacWebKit()) {
> +    if (isIOSWebKit()) {
> +	   $inspectorResourcesDirPath = $productDir .
"/WebCore.framework/inspector";
> +    } elsif (isAppleMacWebKit()) {

I would have preferred to check isIOSWebKit() inside isAppleMacWebKit().