[webkit-reviews] review granted: [Bug 119171] Allow new transitions to run even when controller is suspended : [Attachment 207566] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 119171: Allow new transitions to run even when controller is suspended
https://bugs.webkit.org/show_bug.cgi?id=119171

Attachment 207566: Patch
https://bugs.webkit.org/attachment.cgi?id=207566&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207566&action=review


> Source/WebCore/ChangeLog:21
> +	   (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
Initialize new flag to false.
> +	  
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): Expose
getter.
> +	  
(WebCore::AnimationControllerPrivate::setAllowNewAnimationsWhileSuspended):
Expose setter.
> +	   (WebCore::AnimationController::allowNewAnimationsWhileSuspended):
"Public" getter.
> +	   (WebCore::AnimationController::setAllowNewAnimationsWhileSuspended):
"Public" setter.

Are these up-to-date with the code changes?

> Source/WebCore/page/animation/AnimationController.h:81
> +    bool allowNewAnimationsWhileSuspended() const;
> +    void setAllowNewAnimationsWhileSuspended(bool);

allow -> allows

> Source/WebCore/page/animation/AnimationControllerPrivate.h:114
> +    bool allowNewAnimationsWhileSuspended() const { return
m_allowNewAnimationsWhileSuspended; }
> +    void setAllowNewAnimationsWhileSuspended(bool);

allow -> allows

> Source/WebCore/page/animation/AnimationControllerPrivate.h:148
> +    bool m_allowNewAnimationsWhileSuspended;

allows. might want to add a comment to explain why this is here.

> Source/WebKit/mac/WebView/WebViewPrivate.h:568
> +- (BOOL)allowNewCSSAnimationsWhileSuspended;
> +- (void)setAllowNewCSSAnimationsWhileSuspended:(BOOL)allowed;

allows