[webkit-reviews] review granted: [Bug 119075] With frame flattening on, too many resize events fired if document is resized in onresize handler. : [Attachment 207557] Don't send resize event when widget frame is being changed in RenderFrameBase::layoutWithFlattening.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 119075: With frame flattening on, too many resize events fired if document
is resized in onresize handler.
https://bugs.webkit.org/show_bug.cgi?id=119075

Attachment 207557: Don't send resize event when widget frame is being changed
in RenderFrameBase::layoutWithFlattening. 
https://bugs.webkit.org/attachment.cgi?id=207557&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207557&action=review


> Source/WebCore/ChangeLog:8
> +	   With http://trac.webkit.org/changeset/149287, WebCore also send
resize event in FrameView::setFrameRect.  When

sends

> Source/WebCore/ChangeLog:12
> +	   is done layout.

is done laying out

> Source/WebCore/page/FrameView.h:441
> +    void setResizeEventAllowed(bool resizeEventAllowed) {
m_resizeEventAllowed = resizeEventAllowed; }

Might as well add a const inline setter for this too.

This currently doesn't allow nesting. Does it need to (using a counter)?

> Source/WebCore/rendering/RenderFrameBase.cpp:68
> +    childFrameView->setResizeEventAllowed(false);

Could TemporaryChange<> help you here?