[webkit-reviews] review denied: [Bug 119161] Windows WebGL build needs more include directories : [Attachment 207553] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 119161: Windows WebGL build needs more include directories
https://bugs.webkit.org/show_bug.cgi?id=119161

Attachment 207553: Patch
https://bugs.webkit.org/attachment.cgi?id=207553&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207553&action=review


You snuck a Cairo header path into the common build.  This might cause errors
when building for Apple Windows.  Can you please move that one include to the
WebCoreCairo.props file?  The other Cairo paths are already there -- looks like
I missed that one.

> Source/WebCore/WebCore.vcxproj/WebCoreCommon.props:10
> +	
<AdditionalIncludeDirectories>$(ProjectDir)..;$(ProjectDir)..\Modules\filesyste
m;$(ProjectDir)..\Modules\geolocation;$(ProjectDir)..\Modules\indexeddb;$(Proje
ctDir)..\Modules\mediasource;$(ProjectDir)..\Modules\navigatorcontentutils;$(Pr
ojectDir)..\Modules\speech;$(ProjectDir)..\Modules\proximity;$(ProjectDir)..\Mo
dules\quota;$(ProjectDir)..\Modules\notifications;$(ProjectDir)..\Modules\webda
tabase;$(ProjectDir)..\Modules\websockets;$(ProjectDir)..\accessibility;$(Proje
ctDir)..\accessibility\win;$(ProjectDir)..\bridge;$(ProjectDir)..\bridge\c;$(Pr
ojectDir)..\bridge\jsc;$(ProjectDir)..\css;$(ProjectDir)..\editing;$(ProjectDir
)..\fileapi;$(ProjectDir)..\rendering;$(ProjectDir)..\rendering\mathml;$(Projec
tDir)..\rendering\style;$(ProjectDir)..\rendering\svg;$(ProjectDir)..\bindings;
$(ProjectDir)..\bindings\generic;$(ProjectDir)..\bindings\js;$(ProjectDir)..\bi
ndings\js\specialization;$(ProjectDir)..\dom;$(ProjectDir)..\dom\default;$(Proj
ectDir)..\history;$(ProjectDir)..\html;$(ProjectDir)..\html\canvas;$(ProjectDir
)..\html\forms;$(ProjectDir)..\html\parser;$(ProjectDir)..\html\shadow;$(Projec
tDir)..\html\track;$(ProjectDir)..\inspector;$(ProjectDir)..\loader;$(ProjectDi
r)..\loader\appcache;$(ProjectDir)..\loader\archive;$(ProjectDir)..\loader\arch
ive\cf;$(ProjectDir)..\loader\cache;$(ProjectDir)..\loader\icon;$(ProjectDir)..
\mathml;$(ProjectDir)..\page;$(ProjectDir)..\page\animation;$(ProjectDir)..\pag
e\scrolling;$(ProjectDir)..\page\win;$(ProjectDir)..\platform;$(ProjectDir)..\p
latform\animation;$(ProjectDir)..\platform\mock;$(ProjectDir)..\platform\sql;$(
ProjectDir)..\platform\win;$(ProjectDir)..\platform\network;$(ProjectDir)..\pla
tform\network\win;$(ProjectDir)..\platform\cf;$(ProjectDir)..\platform\graphics
;$(ProjectDir)..\platform\graphics\ca;$(ProjectDir)..\platform\graphics\cpu\arm
\filters;$(ProjectDir)..\platform\graphics\filters;$(ProjectDir)..\platform\gra
phics\filters\arm;$(ProjectDir)..\platform\graphics\opentype;$(ProjectDir)..\pl
atform\graphics\transforms;$(ProjectDir)..\platform\text;$(ProjectDir)..\platfo
rm\text\transcoder;$(ProjectDir)..\platform\graphics\win;$(ProjectDir)..\xml;$(
ProjectDir)..\xml\parser;$(ConfigurationBuildDir)\obj32\WebCore\DerivedSources;
$(ProjectDir)..\plugins;$(ProjectDir)..\plugins\win;$(ProjectDir)..\svg\animati
on;$(ProjectDir)..\svg\graphics;$(ProjectDir)..\svg\properties;$(ProjectDir)..\
svg\graphics\filters;$(ProjectDir)..\svg;$(ProjectDir)..\testing;$(ProjectDir).
.\wml;$(ProjectDir)..\storage;$(ProjectDir)..\websockets;$(ProjectDir)..\worker
s;$(ConfigurationBuildDir)\include;$(ConfigurationBuildDir)\include\private;$(C
onfigurationBuildDir)\include\JavaScriptCore;$(ConfigurationBuildDir)\include\p
rivate\JavaScriptCore;$(ProjectDir)..\ForwardingHeaders;$(ProjectDir)..\platfor
m\graphics\gpu;$(ProjectDir)..\platform\graphics\cairo;$(ProjectDir)..\platform
\graphics\egl;$(ProjectDir)..\platform\graphics\surfaces\egl;$(ProjectDir)..\pl
atform\graphics\opengl;$(WebKit_Libraries)\include;$(WebKit_Libraries)\include\
private;$(WebKit_Libraries)\include\private\JavaScriptCore;$(WebKit_Libraries)\
include\sqlite;$(WebKit_Libraries)\include\JavaScriptCore;$(WebKit_Libraries)\i
nclude\zlib;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>

The "$(ProjectDir)..\platform\graphics\cairo" should go in the
WebCoreCairo.props file.