[webkit-reviews] review granted: [Bug 119085] [EFL][WK2] Simplify context_menu_spelling_items_availability unit test : [Attachment 207520] apply Gyuyoung's review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 26 10:34:12 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 119085: [EFL][WK2] Simplify context_menu_spelling_items_availability unit
test
https://bugs.webkit.org/show_bug.cgi?id=119085

Attachment 207520: apply Gyuyoung's review
https://bugs.webkit.org/attachment.cgi?id=207520&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207520&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:-559
> -	   ecore_main_loop_iterate();

When I ask EFL community this function, I could get this reply....
"DO NOT use this function unless you are the person God comes to ask for advice
when He has trouble managing the Universe"

Hey, greg, ryuan and chris, let's think about this function. As we know, we are
not GOD. ;)


More information about the webkit-reviews mailing list