[webkit-reviews] review granted: [Bug 119103] ANGLE needs Windows build system : [Attachment 207482] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 119103: ANGLE needs Windows build system
https://bugs.webkit.org/show_bug.cgi?id=119103

Attachment 207482: Patch
https://bugs.webkit.org/attachment.cgi?id=207482&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207482&action=review


r=me

> Source/ThirdParty/ANGLE/ANGLE.vcxproj/ANGLEGenerated.vcxproj:130
> +   
<NMakePreprocessorDefinitions>WIN32;NDEBUG;</NMakePreprocessorDefinitions>

Stuff like this should be coming from the property sheets.  Visual Studio seeds
this automatically, so it's probably just a matter of deleting the "local"
override of the settings from the property sheet.

You can land as-is and we can clean up in a separate step.