[webkit-reviews] review denied: [Bug 119093] AX: overflow bounding boxes are way too big; prevents VoiceOver taps from activating the right elements : [Attachment 207464] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 25 11:25:08 PDT 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 119093: AX: overflow bounding boxes are way too big; prevents VoiceOver
taps from activating the right elements
https://bugs.webkit.org/show_bug.cgi?id=119093
Attachment 207464: patch
https://bugs.webkit.org/attachment.cgi?id=207464&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
This doesn'ts seem right. absoluteFocusRingQuads() is just that: focus ring
quads in absolute coordinates, so there should be no need to pass in a repaint
container.
I suspect the real issue might be suggested by the comment:
// FIXME: addFocusRingRects() needs to be passed this transform-unaware
// localToAbsolute() offset here because RenderInline::addFocusRingRects()
// implicitly assumes that. This doesn't work correctly with transformed
// descendants.
More information about the webkit-reviews
mailing list