[webkit-reviews] review denied: [Bug 66027] Implementation for "nav-up" "nav-down" "nav-left" "nav-right" properties in CSS3-UI module : [Attachment 207442] patch for latest webkit

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied kyounga
<kyounga.ra at gmail.com>'s request for review:
Bug 66027: Implementation for "nav-up" "nav-down" "nav-left" "nav-right"
properties in CSS3-UI module
https://bugs.webkit.org/show_bug.cgi?id=66027

Attachment 207442: patch for latest webkit
https://bugs.webkit.org/attachment.cgi?id=207442&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207442&action=review


It needs review on the style change. I only reviewed it overly and specially
the FocusController change.

1) it needs a proper changelog entry
2) it needs tests. maybe lots...

r- for now. It looks to be in the right track though.

> Source/WebCore/ChangeLog:9
> +	   Support directional focus navigation properties(nav-[dir]) in CSS UI
module.
> +	   https://bugs.webkit.org/show_bug.cgi?id=66027
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests (OOPS!).
> +

Please explain your solution here, preferably with per function change entries
(see below)

> Source/WebCore/page/FocusController.cpp:945
> +    // If we were in the autoscroll/panScroll mode we want to stop it.
> +    curFrame->eventHandler()->stopAutoscrollTimer();

this needs a test, I would say.

> Source/WebCore/page/FocusController.cpp:962
> +    if (focused == anchor)
> +	   return true;

this needs a test.

> Source/WebCore/page/FocusController.cpp:964
> +    anchor->scrollIntoViewIfNeeded(false);

add a comment saying what "false" is. e.g. (false /*bleh*/)