[webkit-reviews] review denied: [Bug 119030] Move platform-specific implementation of the color picker : [Attachment 207425] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Ruth Fong
<ruthiecftg at gmail.com>'s request for review:
Bug 119030: Move platform-specific implementation of the color picker
https://bugs.webkit.org/show_bug.cgi?id=119030

Attachment 207425: Patch
https://bugs.webkit.org/attachment.cgi?id=207425&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Adding the new file to xcodeproj is not right - I think that it would need be
added to Source/WebKit2/PlatformEfl.cmake if we agreed that it's platform
specific.

But I don't think that the code is platform specific. It just does things in a
way that's either different or plain incorrect. In the former case, we should
some up with a better way to describe and conditionalize it. In the latter way,
it should be replaced with correct code (this is WebKit2).