[webkit-reviews] review granted: [Bug 119025] Rename WebColorChooserProxy : [Attachment 207417] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 119025: Rename WebColorChooserProxy
https://bugs.webkit.org/show_bug.cgi?id=119025

Attachment 207417: Patch
https://bugs.webkit.org/attachment.cgi?id=207417&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207417&action=review


> Source/WebKit2/ChangeLog:10
> +	   Rename WebColorChooserProxy to WebColorPicker since the name
WebColorChoooserProxy
> +	   implies a one-to-one relationship with WebColorChooser, which will
not be true when
> +	   the patch for bug 61276 lands.

Nitpick - It's not even true *now*

Yes, the WebProcess has 1 WebColorChooser, and the UIProcess has 1
WebColorChooserProxy...  but they aren't actually connected.

The Object/ObjectProxy naming scheme is for a pair of objects that represent
the identical object/concept on both sides of the IPC connection, so tightly
intertwined that they message each other directly.