[webkit-reviews] review granted: [Bug 118908] [ATK] Issues with edge cases when getting offsets for a text range in AtkText : [Attachment 207114] Patch proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 118908: [ATK] Issues with edge cases when getting offsets for a text range
in AtkText
https://bugs.webkit.org/show_bug.cgi?id=118908

Attachment 207114: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=207114&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207114&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:521
> +    // Default values, unless the contrary is proved.

This comment seems superfluous.

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:538
> +	   startOffset = comparePositions(selection.start(),
firstValidPosition) < 0 ? 0 : accessibilityObjectLength(coreObject);

So if the selection is after the node then you return accessibilityObjectLength
as the start and end offsets?

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:560
> +    int rangeLength = TextIterator::rangeLength(nodeRange.get(), true);

Looks like you can avoid this temporary.