[webkit-reviews] review granted: [Bug 119022] Remove CheckedInt, use Checked<T, RecordOverflow> instead : [Attachment 207375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 10:05:19 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 119022: Remove CheckedInt, use Checked<T, RecordOverflow> instead
https://bugs.webkit.org/show_bug.cgi?id=119022

Attachment 207375: Patch
https://bugs.webkit.org/attachment.cgi?id=207375&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207375&action=review


> Source/WebCore/html/canvas/CheckedInt.h:-822
> -typedef CheckedInt<int8_t>	CheckedInt8;
> -typedef CheckedInt<uint8_t>	CheckedUint8;
> -typedef CheckedInt<int16_t>	CheckedInt16;
> -typedef CheckedInt<uint16_t> CheckedUint16;
> -typedef CheckedInt<int32_t>	CheckedInt32;
> -typedef CheckedInt<uint32_t> CheckedUint32;
> -typedef CheckedInt<int64_t>	CheckedInt64;
> -typedef CheckedInt<uint64_t> CheckedUint64;

If we wanted we could add these typedefs (with the record variant) to
CheckedArithmetic -- they weren't there in the past due to conflicts with these
typedefs


More information about the webkit-reviews mailing list