[webkit-reviews] review requested: [Bug 116853] ASSERTION FAILED: low in JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset : [Attachment 207364] patch 3

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 116853: ASSERTION FAILED: low in
JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset
https://bugs.webkit.org/show_bug.cgi?id=116853

Attachment 207364: patch 3
https://bugs.webkit.org/attachment.cgi?id=207364&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Patch 3 adds expression info for 2 cases in BinaryOpNode::emit:
1. the strcat case
2. the general case

It does not add expression info for the "compare with null" case because that
case cannot throw due to type coercion.  Hence, it does not needed the
expression info.

Note: this bug original complains of an assertion failure.  That assertion was
removed in http://trac.webkit.org/changeset/152494.  However, this patch does
add 2 test cases to the fast/js/line-column-number.html layout test.  The fix
in this patch is needed to provide more accurate line and column info for these
2 test cases.