[webkit-reviews] review requested: [Bug 117885] [CSS Shapes] Fixed shape size on an auto height container should determine the containing block's height : [Attachment 207358] incorporating review

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 117885: [CSS Shapes] Fixed shape size on an auto height container should
determine the containing block's height
https://bugs.webkit.org/show_bug.cgi?id=117885

Attachment 207358: incorporating review
https://bugs.webkit.org/attachment.cgi?id=207358&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #5)
> This is misplaced. computeLogicalHeight is not about modifying intrinsic
heights. I think you should do this in RenderBlock's layout method, since it is
similar to the expansion we do for floats. I think it should go there instead
of in RenderBox, where it's clearly misplaced.

Fixed.