[webkit-reviews] review granted: [Bug 118993] Dictionary hotkey does not work on vertical text : [Attachment 207340] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 11:45:44 PDT 2013


Enrica Casucci <enrica at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 118993: Dictionary hotkey does not work on vertical text
https://bugs.webkit.org/show_bug.cgi?id=118993

Attachment 207340: proposed fix
https://bugs.webkit.org/attachment.cgi?id=207340&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207340&action=review


> Source/WebCore/editing/Editor.cpp:2694
> +    bool startCaretIsVertical = startCaretRect.width() == caretWidth;

I think it would be more clear if you named this variable to indicate the
direction of the text rather than the caret. Here caret is vertical mean text
is horizontal and that confused me.


More information about the webkit-reviews mailing list