[webkit-reviews] review requested: [Bug 118662] ASSERTION FAILED: divot >= divotLineStart in JSC::ASTBuilder::setExceptionLocation : [Attachment 207327] patch 4: added some static casts to make the Windows build happy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 08:02:11 PDT 2013


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 118662: ASSERTION FAILED: divot >= divotLineStart in
JSC::ASTBuilder::setExceptionLocation
https://bugs.webkit.org/show_bug.cgi?id=118662

Attachment 207327: patch 4: added some static casts to make the Windows build
happy.
https://bugs.webkit.org/attachment.cgi?id=207327&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Brent tells me that the Windows build is still unhappy and not able to decide
whether to cast the uint16_t m_subexpressionStartOffset into an int or unsigned
in ThrowableSubExpressionData and ThrowablePrefixedSubExpressionData.  This
patch adds explicit casts where needed to disambiguate that for the VS
compiler.


More information about the webkit-reviews mailing list