[webkit-reviews] review denied: [Bug 118936] Extract a function to compute the zoom adjust values for paddings and margings : [Attachment 207262] Fixed the test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 22 13:44:59 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 118936: Extract a function to compute the zoom adjust values for paddings
and margings
https://bugs.webkit.org/show_bug.cgi?id=118936

Attachment 207262: Fixed the test
https://bugs.webkit.org/attachment.cgi?id=207262&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207262&action=review


> Source/WebCore/ChangeLog:10
> +	   Extract a function to compute the zoom adjust values for paddings
and margings
> +	   https://bugs.webkit.org/show_bug.cgi?id=118936
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Extracted zoomAdjustedPaddingOrMarginPixelValue and used it to
compute
> +	   the zoom adjust values for margings and paddings to reduce the code
duplication.
> +

This needs to make it clear that there's a behavior change.


More information about the webkit-reviews mailing list