[webkit-reviews] review denied: [Bug 118951] REGRESSION(r152227) Images with layer backing don't show up unless the containing window is resized. : [Attachment 207242] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 118951: REGRESSION(r152227) Images with layer backing don't show up unless
the containing window is resized.
https://bugs.webkit.org/show_bug.cgi?id=118951

Attachment 207242: Patch
https://bugs.webkit.org/attachment.cgi?id=207242&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207242&action=review


> Source/WebCore/ChangeLog:13
> +	   Ensure that the content rect is initialized when the image is set on
the graphics layer.
> +
> +	   RenderLayerBacking::updateGraphicsLayerGeometry() only updates the
contents rect when
> +	   the associated graphics layer has a content layer. Since the
positioned image
> +	   gets committed on the graphics layer after the update calls, the
contents rect
> +	   is left uninitialized.

There should be regression information here.

> LayoutTests/compositing/images/positioned-image-content-rect.html:5
> +    <img style="position: fixed; top:0px; left:0px;" width="214px"
height="232px" src="../resources/apple.jpg">

A better way to get a composited image is to use -webkit-transfrom:
translateZ(0). Not all platforms will enable compositing for fixed.