[webkit-reviews] review granted: [Bug 118959] Web Inspector: Cleanup InspectorFrontendHostStub.js : [Attachment 207221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 21 20:01:05 PDT 2013


Timothy Hatcher <timothy at apple.com> has granted Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 118959: Web Inspector: Cleanup InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=118959

Attachment 207221: Patch
https://bugs.webkit.org/attachment.cgi?id=207221&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207221&action=review


> Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:-125
> -	       if (this._fileBuffers[url])
> -		   throw new Error("Concurrent file modification denied.");
> -
> -	       this._fileBuffers[url] = [content];
> -	   },

We do use save, which you kept. I agree, this implementation does nothing
unless close is also called. So it is weird.


More information about the webkit-reviews mailing list