[webkit-reviews] review granted: [Bug 118910] fourthTier: DFG Nodes should be able to abstractly tell you what they read and what they write : [Attachment 207214] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 118910: fourthTier: DFG Nodes should be able to abstractly tell you what
they read and what they write
https://bugs.webkit.org/show_bug.cgi?id=118910

Attachment 207214: the patch
https://bugs.webkit.org/attachment.cgi?id=207214&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207214&action=review


Is there anyway to test all this (is it worth it to unit test it)?  Or will I
have to wait for LICM?

> Source/JavaScriptCore/dfg/DFGAbstractHeap.h:275
> +    int64_t m_value;

Even though it is not too confusing, you should probably add a short comment
explaining the structure of m_value, bitwise.

> Source/JavaScriptCore/dfg/DFGClobberSet.cpp:106
> +    out.print("(Direct:[", sortedListDump(direct()), "], Super:[",
sortedListDump(super()), "])");

Please adding timing information so you can have a function called
clobberingTime().