[webkit-reviews] review granted: [Bug 118953] Java Updater not launched on Lion and Mountain Lion : [Attachment 207210] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 118953: Java Updater not launched on Lion and Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=118953

Attachment 207210: Patch
https://bugs.webkit.org/attachment.cgi?id=207210&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207210&action=review


> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:413
> +    NSURL *url = [NSURL URLWithString:urlString];
> +    if (![url isFileURL])
> +	   return false;
>  
> -    return [[NSURL URLWithString:urlString] isEqual:javaUpdaterURL];
> +    NSString *javaUpdaterPath = [NSString pathWithComponents:[NSArray
arrayWithObjects:(NSString *)pluginProcessAttributes.moduleInfo.path,
@"Contents/Resources/Java Updater.app", nil]];
> +    return [url.path isEqualToString:javaUpdaterPath];

This could either use a comment.