[webkit-reviews] review granted: [Bug 118468] [Curl] Download fails for certain urls. : [Attachment 206260] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 118468: [Curl] Download fails for certain urls.
https://bugs.webkit.org/show_bug.cgi?id=118468

Attachment 206260: Patch
https://bugs.webkit.org/attachment.cgi?id=206260&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206260&action=review


Looks good.  Please address my minor comments when you land!

> Source/WebCore/platform/network/curl/CurlDownload.cpp:352
> +	       String value = it->value;

This could be a const reference to avoid a copy.

> Source/WebCore/platform/network/curl/CurlDownload.cpp:353
> +	       String headerString(key);

You convert an AtomicString to a String in 351, then make a copy here.	Why not
just do "String headerString(it->key);"?

> Source/WebCore/platform/network/curl/CurlDownload.cpp:405
> +    writeDataToFile(static_cast<char*>(data), size);

Why are you casting to a char*?  The function signature is "const char*".