[webkit-reviews] review granted: [Bug 114867] [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK : [Attachment 207192] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 20 12:23:08 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 114867: [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867

Attachment 207192: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=207192&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207192&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:1075
> +    return resultText.release();

I think if you always release the resultText then perhaps just a raw pointer
works.


More information about the webkit-reviews mailing list