[webkit-reviews] review granted: [Bug 118930] Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue : [Attachment 207160] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 17:50:11 PDT 2013


Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 118930: Extract computeRenderStyleForProperty and
nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue
https://bugs.webkit.org/show_bug.cgi?id=118930

Attachment 207160: Cleanup
https://bugs.webkit.org/attachment.cgi?id=207160&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207160&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1576
> +    for (Node* n = styledNode; n && !needsStyleRecalc; n = n->parentNode())
// FIXME: Call parentOrShadowHostNode() instead
> +	   needsStyleRecalc = n->needsStyleRecalc();
> +    return needsStyleRecalc;

We should just return (true) immediately if we encounter an ancestor that needs
style recalc.


More information about the webkit-reviews mailing list