[webkit-reviews] review granted: [Bug 118924] AX: VoiceOver not detecting misspelled words doesn't work in all cases : [Attachment 207154] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 118924: AX: VoiceOver not detecting misspelled words doesn't work in all
cases
https://bugs.webkit.org/show_bug.cgi?id=118924

Attachment 207154: patch
https://bugs.webkit.org/attachment.cgi?id=207154&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207154&action=review


> Tools/ChangeLog:8
> +	   Make the misspelled detection dependent on both types of attributes
to be present.

Grammar. s/to be/being/, I think.

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:909
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080

We almost universally use >= and the version that it was first introduced in.
You should do the same.

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:911
> +    if (misspelled)
> +	   misspelled = [[attrs
objectForKey:NSAccessibilityMarkedMisspelledTextAttribute] boolValue];

This looks funny but is fine.