[webkit-reviews] review granted: [Bug 118926] ANGLE does not compile with code coverage analysis : [Attachment 207156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 16:19:33 PDT 2013


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 118926: ANGLE does not compile with code coverage analysis
https://bugs.webkit.org/show_bug.cgi?id=118926

Attachment 207156: Patch
https://bugs.webkit.org/attachment.cgi?id=207156&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review


> Tools/ChangeLog:10
> +	   * Scripts/build-webkit: Removed exception preventing ANGLE code
coverage support.
> +	   * Scripts/generate-coverage-data: Added --no-build to
run-javascriptcore-tests call.
> +	   (generateReport): Moved report generation to a subroutine.

You did things that you didn’t mention here.

> Tools/Scripts/build-webkit:-329
> -	   push @local_options, XcodeCoverageSupportOptions() if
$coverageSupport && $project ne "ANGLE";

Do you know historically where this came from? it seems surprisingly specific.

> Tools/Scripts/generate-coverage-data:61
> +system("Tools/Scripts/run-javascriptcore-tests --no-build");

why just —no-build for jsc tests? I think most of the others support that too.


More information about the webkit-reviews mailing list