[webkit-reviews] review denied: [Bug 118898] Make atob() throw an InvalidCharacterError on excess padding characters : [Attachment 207081] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 14:47:48 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 118898: Make atob() throw an InvalidCharacterError on excess padding
characters
https://bugs.webkit.org/show_bug.cgi?id=118898

Attachment 207081: Patch
https://bugs.webkit.org/attachment.cgi?id=207081&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
We don't need the pay the cost of this at runtime. You can have two functions,
with and without padding, and make Base64PaddingValidationPolicy a template
parameter.


More information about the webkit-reviews mailing list