[webkit-reviews] review granted: [Bug 118872] Mac port should run bison as part of ANGLE build process : [Attachment 207140] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 118872: Mac port should run bison as part of ANGLE build process
https://bugs.webkit.org/show_bug.cgi?id=118872

Attachment 207140: Patch
https://bugs.webkit.org/attachment.cgi?id=207140&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207140&action=review


r=me with the two minor issues.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +	   * ANGLE.xcodeproj/project.pbxproj: Made Derived Sources target which
calls DerivedSources.make, moved generated files into Derived Sources group.

It'd be good to wrap this line somewhere so it's not dramatically longer than
the rest of the lines in this file.

> Source/ThirdParty/ANGLE/DerivedSources.make:15
> +#	 documentation and/or other materials provided with the distribution.
> +# 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> +#	 its contributors may be used to endorse or promote products derived
> +#	 from this software without specific prior written permission.
> +#

This is an old version of an old license we used to use. Take a look at
Source/WebCore/LICENSE-APPLE for the current license.