[webkit-reviews] review granted: [Bug 118878] fourthTier: Structure should be able to tell you if it's valid to load at a given offset from any object with that structure : [Attachment 207125] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 118878: fourthTier: Structure should be able to tell you if it's valid to
load at a given offset from any object with that structure
https://bugs.webkit.org/show_bug.cgi?id=118878

Attachment 207125: the patch
https://bugs.webkit.org/attachment.cgi?id=207125&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207125&action=review


> Source/JavaScriptCore/ChangeLog:35
> +	   that could transitively try to compute the hash from the source
code. The source
> +	   code is a string that may be lazily computed, and that involves all
manner of thread
> +	   unsafe things.

Do we have any assertions that would catch this?