[webkit-reviews] review denied: [Bug 118887] WebKitExports.def.in needs 64-bit symbols : [Attachment 207056] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 118887: WebKitExports.def.in needs 64-bit symbols
https://bugs.webkit.org/show_bug.cgi?id=118887

Attachment 207056: Patch
https://bugs.webkit.org/attachment.cgi?id=207056&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207056&action=review


> Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:115
> +	   symbolWithPointer(?fastMalloc at WTF@@YAPAXI at Z,
?fastMalloc at WTF@@YAPEAX_K at Z)

We are getting a compile failure when we attempt to compile the output of this
macro (as processed by the build script).  Take a look at the intermediary
output: WebKitExports.def.in gets converted to
$(WebKitOutput)\obj(32|64)\WebKitExportGenerator\DerivedSources\WebKitExportsGe
nerator.cpp.  This is processed by the compiler as a series of 'printf'
statements.  Somehow, the trailing end of the symbol is getting appended with a
")'".