[webkit-reviews] review denied: [Bug 118872] Mac port should run bison as part of ANGLE build process : [Attachment 207036] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 118872: Mac port should run bison as part of ANGLE build process
https://bugs.webkit.org/show_bug.cgi?id=118872

Attachment 207036: Patch
https://bugs.webkit.org/attachment.cgi?id=207036&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207036&action=review


Marking as r- based on feedback above.

> Source/ThirdParty/ANGLE/ChangeLog:4
> +	   ANGLE has 5 files that are generated.  These should generated as
part of the build process to make updating easier.
> +	   https://bugs.webkit.org/show_bug.cgi?id=118872

The first line here could be more succinct. Something like "Generate derived
files in ANGLE at build time rather than when updating from upstream."